Skip to content

🎨 Use async Redis client in Celery #7430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

🎨 Use async Redis client in Celery #7430

wants to merge 15 commits into from

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Mar 26, 2025 •
edited
Loading

What do these changes do?

When listing the completed tasks, our async Redis client is used from now.
Completely removed the blocking call control.inspect().

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo self-assigned this Mar 26, 2025
@giancarloromeo giancarloromeo marked this pull request as ready for review March 26, 2025 09:57
sanderegg
sanderegg reviewed Mar 26, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure your change will pass the tests. I would suggest to pass the fastapi app as a field. this get_fastapi_app is what you normally use in the worker.

@codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.72727% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (0d58ad8) to head (4a06f20).
Report is 15 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (0d58ad8) and HEAD (4a06f20). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (0d58ad8) HEAD (4a06f20)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7430       +/-   ##
===========================================
- Coverage   87.45%   68.79%   -18.67%     
===========================================
  Files        1717      729      -988     
  Lines       66614    34327    -32287     
  Branches     1132      168      -964     
===========================================
- Hits        58259    23615    -34644     
- Misses       8034    10654     +2620     
+ Partials      321       58      -263
Flag Coverage Δ
integrationtests 65.17% <ø> (-0.01%) ⬇️
unittests 85.94% <92.72%> (-0.69%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.54% <ø> (-12.77%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 85.94% <92.72%> (-0.44%) ⬇️
webclient ∅ <ø> (∅)
webserver 59.12% <ø> (-26.79%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d58ad8...4a06f20. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo added this to the The Awakening milestone Mar 26, 2025
@giancarloromeo giancarloromeo added the a:storage issue related to storage service label Mar 27, 2025
sanderegg
sanderegg reviewed Mar 27, 2025
View reviewed changes
services/storage/src/simcore_service_storage/modules/celery/models.py


class TaskData(BaseModel):
status: str
Copy link
Member

@sanderegg sanderegg Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 27, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This was referenced Mar 27, 2025
Closed
Merged
@giancarloromeo
Copy link
Contributor Author

giancarloromeo commented Apr 2, 2025

PR closed, code is present in #7443

@giancarloromeo giancarloromeo deleted the use-async-redis-client branch April 2, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanderegg sanderegg sanderegg left review comments

Assignees

@giancarloromeo giancarloromeo

Labels

a:storage issue related to storage service

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

2 participants

@giancarloromeo @sanderegg